-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump rollup typescript, remove unused micromatch #4219
chore: bump rollup typescript, remove unused micromatch #4219
Conversation
d8dcebd
to
094753b
Compare
094753b
to
48a11b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4219 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 202 202
Lines 7259 7260 +1
Branches 2119 2119
=======================================
+ Hits 7141 7142 +1
Misses 58 58
Partials 60 60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One reason I never updated the TypeScript plugin is because the old one actually allowed you to write invalid code to try out stuff 馃槣 I guess that is what previously "fixed" the fsevents types. But I agree that we should update, especially since performance seems to be pretty neat by now.
Do you know if there is a way to get rid of the CreatingProgramWith::
log when building? It seems to be something done by the TypeScript compiler.
Sounds like a plan, though this could have quite some impact on build times which again would have some impact on test execution times, but maybe there are solutions. At least on CI, I would hope that we run tests against the compiled version of Rollup just like an end user would do. I guess if one were to make a PR for this, we can definitely talk about it. Depending on how it is done, one might also use TypeScripts watch mode (rather than ts-node) for local test executions, which might give a nice speed boost. There is also a long-standing issue about this. |
ah, I see, that would explain it 馃槃 . also just found this: https://github.com/rollup/plugins/tree/master/packages/typescript#faster-compiling that seems to bit unfortunate, I like to turn off type checking once in a while as well, as you can prototype faster. e.g. with the ts-node --transpile-only flag.
I looked into the typescript code and that log is emitted with the |
14eb48d
to
88d6f35
Compare
a3def8a
to
8f3a82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect now 馃槈
Ah, good digging, thanks a lot. So it was our own fault, but we never noticed because before, the flag was ignored. Now it looks nice like it should. |
BTW if you notice the license file having a lot of changes after you install something, the reason is that for some reason, the package files in node_modules look slightly differently depending on whether you last used |
ah, thank you, good to know! that sounds like a bug with npm. 馃 |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
rollup-plugin-typescript
to latest@rollup/plugin-typescript
. there appears to be a problem with thefsevents
module and types under linux/windows, as those are optional deps and only installed on macOS. I had to use anany
type to get around the typing problem. I'm not sure why and how it worked previously. 馃rollup-pluginutils
to latest@rollup/pluginutils
, fix importsmicromatch
+types/micromatch
rollup
to latest. on that note: wouldn't it be better to dogfood from the source directly?